Conversation
Content validation is done internally in the pixelator package
6 tasks
fbdtemme
approved these changes
Nov 21, 2025
Collaborator
fbdtemme
left a comment
There was a problem hiding this comment.
Very nice!
Only thing I am unsure about is the test scripts. I have not really seen any custom scripts being used in other nf-core repos so maybe the core folks would have issues with that?
I would just leave those out.
Collaborator
|
Maybe it is something to bring to the table and hear what the nf-core folks think about it? Since testing seems to be a pain point for main pipeline as I understand it. |
Contributor
Author
|
I can ask on slack and fix it in a new PR if I get any suggestions, thanks for the review! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second attempt to make it easier and faster to use the tests when developing the pipeline (first attempt was PR #161)
This PR does the following:
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).CHANGELOG.mdis updated.